From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
---|---|
To: | Kuwamura Masaki <kuwamura(at)db(dot)is(dot)i(dot)nagoya-u(dot)ac(dot)jp> |
Cc: | Nathan Bossart <nathandbossart(at)gmail(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: bug fix and documentation improvement about vacuumdb |
Date: | 2023-09-20 11:17:17 |
Message-ID: | C086ECB9-845E-4BE6-9160-F3FE18B48CCD@yesql.se |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> On 20 Sep 2023, at 11:46, Kuwamura Masaki <kuwamura(at)db(dot)is(dot)i(dot)nagoya-u(dot)ac(dot)jp> wrote:
> I think that supporting pattern matching is quite nice.
> But it will be not only tough but also a breaking change, I wonder.
> So I guess this change should be commited either way.
I agree. Supporting pattern matching should, if anyone is interested in
trying, be done separately in its own thread, no need to move the goalposts
here. Sorry if I made it sound like so upthread.
> The attached patch includes new tests for this bug.
> Also, I fixed the current test for -N option seems to be incorrect.
When sending an update, please include the previous patch as well with your new
tests as a 0002 patch in a patchset. The CFBot can only apply and build/test
patches when the entire patchset is attached to the email. The below
testresults indicate that the patch failed the new tests (which in a way is
good since without the fix the tests *should* fail), since the fix patch was
not applied:
http://cfbot.cputube.org/masaki-kuwamura.html
--
Daniel Gustafsson
From | Date | Subject | |
---|---|---|---|
Next Message | Ashutosh Bapat | 2023-09-20 11:18:00 | Re: persist logical slots to disk during shutdown checkpoint |
Previous Message | Ashutosh Bapat | 2023-09-20 11:03:09 | Re: [PoC] Reducing planning time when tables have many partitions |