RE: BUG #15080: ecpg on windows doesn't define HAVE_LONG_LONG_INT

From: Jonathan Allen <jallen(at)americansavingslife(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Meskes <meskes(at)postgresql(dot)org>
Cc: Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>, "pgsql-bugs(at)lists(dot)postgresql(dot)org" <pgsql-bugs(at)lists(dot)postgresql(dot)org>
Subject: RE: BUG #15080: ecpg on windows doesn't define HAVE_LONG_LONG_INT
Date: 2018-02-26 18:28:12
Message-ID: BN6PR17MB1330F6AD0F67C1D34D695CB7DAC10@BN6PR17MB1330.namprd17.prod.outlook.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Right now I'm using a custom build of ecpg to enable Bigint support, but it would suuuuure be nice to have that working in the next release of postgres. I agree, all that's missing is the #define HAVE_LONG_LONG_INT 1 line. :)

-Jonathan

-----Original Message-----
From: Tom Lane [mailto:tgl(at)sss(dot)pgh(dot)pa(dot)us]
Sent: Saturday, February 24, 2018 1:12 PM
To: Michael Meskes <meskes(at)postgresql(dot)org>
Cc: Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>; Jonathan Allen <jallen(at)americansavingslife(dot)com>; pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #15080: ecpg on windows doesn't define HAVE_LONG_LONG_INT

I wrote:
> Michael Meskes <meskes(at)postgresql(dot)org> writes:
>> Right, but it is missing in pg_config.h, too, right?

> No, it does get defined on Unix builds (if appropriate), both in
> pg_config.h and ecpg_config.h.

Oh, wait, now I see what you meant: there is no stanza like

#if (_MSC_VER > 1200)
#define HAVE_LONG_LONG_INT 1
#endif

in pg_config.h.win32. I agree that there should be. As I said, none of the core backend cares at the moment ... but someday, that discrepancy is going to bite us.

regards, tom lane

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Michael Aiello 2018-02-26 18:39:53 RE: BUG #15091: to_number() returns incorrect value
Previous Message Tom Lane 2018-02-26 17:48:29 Re: BUG #15091: to_number() returns incorrect value