Re: Review: plpgsql.extra_warnings, plpgsql.extra_errors

From: Piotr Stefaniak <postgres(at)piotr-stefaniak(dot)me>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Petr Jelinek <petr(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Marko Tiikkaja <marko(at)joh(dot)to>
Subject: Re: Review: plpgsql.extra_warnings, plpgsql.extra_errors
Date: 2014-03-22 17:36:21
Message-ID: BLU0-SMTP154E3352F8488CFDDB2A8B1F2780@phx.gbl
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 03/22/2014 04:00 PM, Tom Lane wrote:
> On the other side, coding with the explicit cast helps guard against far
> more dangerous coding errors, which the compiler will*not* help you with.
> What if myextra is actually of type "int64 *"?
Indeed, neither "gcc -Wall -Wextra -std=c89 -pedantic" nor "clang
-Weverything -Wno-shadow -std=c89 -pedantic" issues a warning in such
case. "clang --analyze", however, does. Perhaps TenDRA would, if it ever
worked.

This message is meant to be merely informative, since I've put some
effort into this test. I'm not trying to argue.

Attachment Content-Type Size
test.c text/plain 789 bytes

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Thom Brown 2014-03-22 18:07:16 Re: Partial index locks
Previous Message Jim Nasby 2014-03-22 16:37:27 Re: ALTER TABLE lock strength reduction patch is unsafe