Re: Review: plpgsql.extra_warnings, plpgsql.extra_errors

From: Piotr Stefaniak <postgres(at)piotr-stefaniak(dot)me>
To: Petr Jelinek <petr(at)2ndquadrant(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Marko Tiikkaja <marko(at)joh(dot)to>
Subject: Re: Review: plpgsql.extra_warnings, plpgsql.extra_errors
Date: 2014-03-22 09:07:56
Message-ID: BLU0-SMTP14947303B98B1E262495046F2780@phx.gbl
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


> + myextra = (int *) malloc(sizeof(int));

Please consider not casting malloc(). See
http://c-faq.com/malloc/mallocnocast.html

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Martijn van Oosterhout 2014-03-22 09:21:06 Re: [RFC] What should we do for reliable WAL archiving?
Previous Message Amit Kapila 2014-03-22 07:47:22 Re: Fwd: Proposal: variant of regclass