From: | "Amonson, Paul D" <paul(dot)d(dot)amonson(at)intel(dot)com> |
---|---|
To: | Nathan Bossart <nathandbossart(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, David Rowley <dgrowleyml(at)gmail(dot)com>, "Andres Freund" <andres(at)anarazel(dot)de>, "Shankaran, Akash" <akash(dot)shankaran(at)intel(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | RE: Popcount optimization using AVX512 |
Date: | 2024-03-29 17:11:18 |
Message-ID: | BL1PR11MB5304DA6242F55DCC7DD05ED9DC3A2@BL1PR11MB5304.namprd11.prod.outlook.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> On Thu, Mar 28, 2024 at 11:10:33PM +0100, Alvaro Herrera wrote:
> > We don't do MSVC via autoconf/Make. We used to have a special build
> > framework for MSVC which parsed Makefiles to produce "solution" files,
> > but it was removed as soon as Meson was mature enough to build. See
> > commit 1301c80b2167. If it builds with Meson, you're good.
>
> The latest cfbot build for this seems to indicate that at least newer MSVC
> knows AVX512 intrinsics without any special compiler flags [0], so maybe
> what I had in v14 is good enough. A previous version of the patch set [1] had
> the following lines:
>
> + if host_system == 'windows'
> + test_flags = ['/arch:AVX512']
> + endif
>
> I'm not sure if this is needed for older MSVC or something else. IIRC I couldn't
> find any other examples of this sort of thing in the meson scripts, either. Paul,
> do you recall why you added this?
I asked internal folks here in-the-know and they suggested I add it. I personally am not a Windows guy. If it works without it and you are comfortable not including the lines, I am fine with it.
Thanks,
Paul
From | Date | Subject | |
---|---|---|---|
Next Message | Amonson, Paul D | 2024-03-29 17:25:14 | RE: Popcount optimization using AVX512 |
Previous Message | Jeff Davis | 2024-03-29 17:09:38 | Re: Comments on Custom RMGRs |