RE: Proposal for Updating CRC32C with AVX-512 Algorithm.

From: "Amonson, Paul D" <paul(dot)d(dot)amonson(at)intel(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, "Shankaran, Akash" <akash(dot)shankaran(at)intel(dot)com>
Subject: RE: Proposal for Updating CRC32C with AVX-512 Algorithm.
Date: 2024-06-12 21:46:19
Message-ID: BL1PR11MB530420CA393530170BADB49ADCC02@BL1PR11MB5304.namprd11.prod.outlook.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


> -----Original Message-----
> From: Andres Freund <andres(at)anarazel(dot)de>
> Sent: Wednesday, June 12, 2024 1:12 PM
> To: Amonson, Paul D <paul(dot)d(dot)amonson(at)intel(dot)com>

> FWIW, I tried the v2 patch on my Xeon Gold 5215 workstation, and dies early
> on with SIGILL:

Nice catch!!! I was testing the bit for the vpclmulqdq in EBX instead of the correct ECX register. New Patch attached. I added defines to make that easier to see those types of bugs rather than a simple index number. I double checked the others as well.

Paul

Attachment Content-Type Size
0001-v3-Feat-Add-AVX512-crc32c-algorithm-to-postgres.patch application/octet-stream 42.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jelte Fennema-Nio 2024-06-12 21:50:15 Re: RFC: adding pytest as a supported test framework
Previous Message Peter Geoghegan 2024-06-12 21:42:29 Re: Harmonizing pg_bsd_indent parameter names