Re: [PATCH] Fix out-of-bouds access (src/common/wchar.c)

> On 17 Feb 2022, at 13:59, Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> wrote:
>
> Em qui., 17 de fev. de 2022 às 09:52, Daniel Gustafsson <daniel(at)yesql(dot)se <mailto:daniel(at)yesql(dot)se>> escreveu:
> > On 17 Feb 2022, at 13:19, Ranier Vilela <ranier(dot)vf(at)gmail(dot)com <mailto:ranier(dot)vf(at)gmail(dot)com>> wrote:
>
> > 1. One #ifdef with a mistake, the correct is _WIN32 and not WIN32.
>
> Can you elaborate on this, we are using WIN32 pretty extensively in the code:
>
> $ git grep "if[n]\{0,1\}def WIN32$"|wc -l
> 511
> $ git grep "if[n]\{0,1\}def _WIN32$"|wc -l
> 2
>
> The _WIN32 cases are in the same ECPG testcase.
>
> Why would _WIN32 be correct in this case?
> Sorry, my fault.
>
> I only use _WIN32 and I jumped to conclusions very quickly.

Question remains though, should src/interfaces/ecpg/test/sql/sqlda.pgc really
be using WIN32 and not _WIN32, or doesn't it matter? (or does it only matter
for consistency?) WIN32 and _WIN32 aren't very informative searchterms to use
for finding more information.

--
Daniel Gustafsson https://vmware.com