| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Fix snapshot reference leak if lo_export fails. |
| Date: | 2021-11-03 19:27:33 |
| Message-ID: | BFA50363-C235-4C75-9CE1-3AE6333B6F60@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
> On 3 Nov 2021, at 18:47, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> wrote:
>
> On 03/11/2021 13:06, Daniel Gustafsson wrote:
>>> On 3 Nov 2021, at 10:44, Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi> wrote:
>>> Fix snapshot reference leak if lo_export fails.
>> This commit seems to lack the update in largeobject_1 as per hamerkop in:
>
> Fixed, thanks!
>
> I'm a bit surprised none of the other Windows systems on the buildfarm complained. The difference in largeobject_1 output is apparently that the 'tenk.data' file uses Windows line endings. I guess that on all the other Windows hosts, git has been configured to use Unix line endings.
Interesting, so when hamerkop is offline (which it was for a month) we don't
have coverage for Windows line endings? That's worth keeping in mind.
--
Daniel Gustafsson https://vmware.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2021-11-04 00:34:38 | pgsql: Add another old commit to git-blame-ignore-revs. |
| Previous Message | Heikki Linnakangas | 2021-11-03 17:47:23 | Re: pgsql: Fix snapshot reference leak if lo_export fails. |