From: | David Christensen <david(at)endpoint(dot)com> |
---|---|
To: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: WIP: Triggers on VIEWs |
Date: | 2010-09-07 01:03:09 |
Message-ID: | BF60FEBD-B00D-4E32-AA5C-D672D3185859@endpoint.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sep 5, 2010, at 3:09 AM, Dean Rasheed wrote:
> On 15 August 2010 18:38, Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> wrote:
>> Here is a WIP patch implementing triggers on VIEWs ... <snip>
>>
>> There are still a number of things left todo:
>> - extend ALTER VIEW with enable/disable trigger commands
>> - much more testing
>> - documentation
>>
>
> Attached is an updated patch with more tests and docs, and a few minor
At least for me, there are some portions of the docs which could use some formatting changes in order to not be confusing grammatically; e.g., this was confusing to me on the first read:
- trigger name. In the case of before triggers, the
+ trigger name. In the case of before and instead of triggers, the
I realize this lack of formatting was inherited from the existing docs, but this would make more sense to me if this (and presumably the other related instances of "before" and "after") were set apart with <literal></> or similar. This is already in use in some places in this patch, so seems like the correct markup.
Regards,
David
--
David Christensen
End Point Corporation
david(at)endpoint(dot)com
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2010-09-07 02:55:39 | update on global temporary and unlogged tables |
Previous Message | Robert Haas | 2010-09-07 00:42:53 | Re: knngist - 0.8 |