| From: | Rajeev rastogi <rajeev(dot)rastogi(at)huawei(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Dangling Client Backend Process |
| Date: | 2015-10-21 03:42:36 |
| Message-ID: | BF2827DCCE55594C8D7A8F7FFD3AB77159968E6D@szxeml521-mbs.china.huawei.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 20 October 2015 23:34, Robert Haas [mailto:robertmhaas(at)gmail(dot)com] Wrote:
>On Tue, Oct 20, 2015 at 12:11 PM, Alvaro Herrera
><alvherre(at)2ndquadrant(dot)com> wrote:
>> Robert Haas wrote:
>>> I don't think that proc_exit(1) is the right way to exit here. It's
>>> not very friendly to exit without at least attempting to give the
>>> client a clue about what has gone wrong. I suggest something like
>>> this:
>>>
>>> ereport(FATAL,
>>> (errcode(ERRCODE_ADMIN_SHUTDOWN),
>>> errmsg("terminating connection due to postmaster
>>> shutdown")));
>>
>> Agreed, but I don't think "shutdown" is the right word to use here --
>> that makes it sound like it was orderly. Perhaps "crash"?
>
>Well, that's a little speculative. "due to unexpected postmaster exit"?
Agreed. Attached is the patch with changes.
Thanks and Regards,
Kumar Rajeev Rastogi
| Attachment | Content-Type | Size |
|---|---|---|
| dangling_backend_process_v2.patch | application/octet-stream | 3.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kouhei Kaigai | 2015-10-21 04:34:34 | Re: Foreign join pushdown vs EvalPlanQual |
| Previous Message | Etsuro Fujita | 2015-10-21 03:30:51 | Re: Foreign join pushdown vs EvalPlanQual |