| From: | Rajeev rastogi <rajeev(dot)rastogi(at)huawei(dot)com> |
|---|---|
| To: | MauMau <maumau307(at)gmail(dot)com> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, "Magnus Hagander" <magnus(at)hagander(dot)net> |
| Subject: | Re: [review] PostgreSQL Service on Windows does not start if data directory given is relative path |
| Date: | 2014-02-24 04:02:31 |
| Message-ID: | BF2827DCCE55594C8D7A8F7FFD3AB7713DDC4220@SZXEML508-MBX.china.huawei.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 22 February 2014 06:16, MauMau Wrote:
Thanks for reviewing again.
> Please make small cosmetic changes so that make_absolute_path() follows
> the
> style of other parts. Then I'll make this ready for committer.
>
> (1)
> Add the function name in the comment as in:
>
> /*
> * make_absolute_path
> *
> * ...existing function descripton
> */
Added.
> (2)
> Add errno description as in:
>
> fprintf(stderr, _("could not get current working directory: %s\n",
> strerror(errno)));
Modified.
Please find the attached modified patch.
Thanks and Regards,
Kumar Rajeev Rastogi
| Attachment | Content-Type | Size |
|---|---|---|
| pgctl_win32service_rel_dbpath_v6.patch | application/octet-stream | 6.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Josh Berkus | 2014-02-24 06:20:14 | Re: jsonb and nested hstore |
| Previous Message | Haribabu Kommi | 2014-02-24 03:41:57 | Re: contrib/cache_scan (Re: What's needed for cache-only table scan?) |