walsender.c, CreateReplicationSlot() currently has this:
slot_name = NameStr(MyReplicationSlot->data.name);
if (cmd->kind == REPLICATION_KIND_LOGICAL)
{
[...]
}
else if (cmd->kind == REPLICATION_KIND_PHYSICAL && cmd->reserve_wal)
{
[...]
}
slot_name = NameStr(MyReplicationSlot->data.name);
The 2nd assignment to slot_name looks unnecessary?
--
Thanks
Bernd