Re: [PATCH] Negative Transition Aggregate Functions (WIP)

From: Florian Pflug <fgp(at)phlo(dot)org>
To: Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>
Cc: David Rowley <dgrowleyml(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Kevin Grittner <kgrittn(at)ymail(dot)com>, Josh Berkus <josh(at)agliodbs(dot)com>, Greg Stark <stark(at)mit(dot)edu>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Negative Transition Aggregate Functions (WIP)
Date: 2014-03-31 00:58:55
Message-ID: BD119B98-54D2-47DE-B31A-2F618C754585@phlo.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mar28, 2014, at 08:58 , Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> wrote:
> On 27 March 2014 21:01, Florian Pflug <fgp(at)phlo(dot)org> wrote:
>> After re-reading the thread, I'd prefer to go with Dean's suggestion, i.e.
>> simply reporting the total number of invocations of the forward transition
>> functions, and the total number of invocations of the reverse transition
>> function, over reporting nothing. The labels of the two counts would simply
>> be "Forward Transitions" and "Reverse Transitions".
>>
>
> That should be "Inverse" not "Reverse" according to the terminology
> agreed upthread.

Ups, yeah.

> Personally, I'm not a big fan of that terminology because "forward"
> and "inverse" aren't natural antonyms. But actually I think that it's
> "forward" that is the wrong word to use, because they actually both
> move (different ends of) the frame forwards. The only alternatives I
> can think of are "direct" and "inverse", which are natural antonyms,
> but I don't want to hold up this patch bikeshedding over this. OTOH
> this is not the first time on this thread that someone has slipped
> into calling them "forward" and "reverse" transitions.

Head and tail come to mind. But having said that, I'd strongly prefer
not to start bikeschedding over this either. It's not user-visible
enough to fuss about it...

Also, for order-independent transfer functions, it really *is* an
inverse functions, in the sense that g(f(x,a),a) = x.

>>> Florian mentioned upthread that the docs hadn't been updated to
>>> reflect the latest changes, so I think they need a little attention.
>>
>> I'll see to updating the docs, and will post a final patch within the next
>> few days.

Attached are updated patches that include the EXPLAIN changes mentioned
above and updated docs.

best regards,
Florian Pflug

Attachment Content-Type Size
invtrans_arith_3283b8.patch application/octet-stream 63.5 KB
invtrans_base_548630.patch application/octet-stream 101.5 KB
invtrans_collecting_0e7079.patch application/octet-stream 32.8 KB
invtrans_docs_0cb944.patch application/octet-stream 22.1 KB
invtrans_minmax_613af3.patch application/octet-stream 71.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Craig Ringer 2014-03-31 02:30:13 GSoC project suggestion: PIVOT ?
Previous Message Иван Парфилов 2014-03-30 20:50:22 GSoC 2014 proposal