| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Fixing build of MSVC with OpenSSL 3.0.0 |
| Date: | 2021-10-19 08:34:10 |
| Message-ID: | BB22F576-9587-48E5-9E1A-803D574F09D6@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 19 Oct 2021, at 07:27, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> Looking at the MSIs of OpenSSL for Win64 and Win32, there are no
> changes in the deliverable names or paths, meaning that something as
> simple as the attached patch is enough to make the build pass.
Makes sense.
> Any opinions?
I think we can tighten the check for GetOpenSSLVersion() a bit since we now now
the range of version in the 1.x.x series. For these checks we know we want
1.1.x or 3.x.x, but never 2.x.x etc.
How about the (untested) attached which encodes that knowledge, as well as dies
on too old OpenSSL versions?
--
Daniel Gustafsson https://vmware.com/
| Attachment | Content-Type | Size |
|---|---|---|
| openssl_win23.diff | application/octet-stream | 1.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro Horiguchi | 2021-10-19 08:34:22 | Re: [PATCH] Prefer getenv("HOME") to find the UNIX home directory |
| Previous Message | Andrew Bille | 2021-10-19 07:39:35 | Re: [Proposal] Global temporary tables |