Re: Another pgindent gripe

From: "Chuck McDevitt" <cmcdevitt(at)greenplum(dot)com>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Neil Conway" <neilc(at)samurai(dot)com>
Cc: "Bruce Momjian" <pgman(at)candle(dot)pha(dot)pa(dot)us>, "Hackers" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Another pgindent gripe
Date: 2005-11-07 18:29:55
Message-ID: BB05A27C22288540A3A3E8F3749B45AB023246FB@MI8NYCMAIL06.Mi8.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Pgindent adds spaces after the stars if it doesn't recognize the thing
before the star as a typedef... Could it be that somehow the list of
typedefs included in pgindent got corrupted?

> -----Original Message-----
> From: pgsql-hackers-owner(at)postgresql(dot)org [mailto:pgsql-hackers-
> owner(at)postgresql(dot)org] On Behalf Of Tom Lane
> Sent: Monday, November 07, 2005 8:19 AM
> To: Neil Conway
> Cc: Bruce Momjian; Hackers
> Subject: Re: [HACKERS] Another pgindent gripe
>
> Neil Conway <neilc(at)samurai(dot)com> writes:
> > On a related note, most of these changes are completely bogus:
>
> >
>
http://developer.postgresql.org/cvsweb.cgi/pgsql/src/pl/plpgsql/src/pl_e
xe
> c.c.diff?r1=1.152;r2=1.153
>
> Oy vey! Why did it insert spaces after the stars in all those
function
> declarations? That's certainly not in conformance with project style
> ... and I don't see it having happened elsewhere.
>
> Seems like pgindent has suffered some significant regressions since
the
> 8.0 run. I thought it had not been changed much at all, but evidently
> that's wrong.
>
> regards, tom lane
>
> ---------------------------(end of
broadcast)---------------------------
> TIP 5: don't forget to increase your free space map settings

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2005-11-07 18:55:48 Re: parameterized limit statements
Previous Message Merlin Moncure 2005-11-07 18:20:32 Re: parameterized limit statements