From: | "Jeremy Kronuz" <kronuz(at)hotmail(dot)com> |
---|---|
To: | pgsql-hackers(at)postgresql(dot)org, pgsql-patches(at)postgresql(dot)org |
Cc: | tgl(at)sss(dot)pgh(dot)pa(dot)us |
Subject: | Re: ISBN/ISSN/ISMN/EAN13 module |
Date: | 2006-09-10 19:30:26 |
Message-ID: | BAY107-F164BD56B7816AF30DE6A05D8350@phx.gbl |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
> > ... Tom, were you able to apply the patch without problems
> > ('cause this is one of the first times I post a patch in a mailing
>list.)
>
>Um, no, doesn't work at all unfortunately:
>
>$ patch --dry <~/ean.patch
>patching file isn.c
>patch: **** malformed patch at line 6: enum isn_type { INVALID, ANY, EAN13,
>ISBN, ISMN, ISSN, UPC };
>
>$
>
>It looks like the patch got whitespace-mangled in transit. With many
>mail programs it works better to add a patch as an attachment than
>to try to include it directly in the message text. Also, we usually
>ask for diff -c rather than diff -u format ... I for one find it easier
>to read.
>
>Please sync the text-conversion issues and resubmit.
>
Tom, I'm attaching the new patch now... it's now using the GET_TEXT(), I've
updated the README and I've used the -c format as you suggested.
Please, let me know how it goes for you.
Regards,
Kronuz.
Attachment | Content-Type | Size |
---|---|---|
isn2c.diff | application/octet-stream | 24.3 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Martijn van Oosterhout | 2006-09-10 20:21:13 | Re: Fixed length data types issue |
Previous Message | Joshua D. Drake | 2006-09-10 19:09:24 | Re: contrib uninstall scripts need some love |
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Fuhr | 2006-09-10 20:23:02 | Re: contrib uninstall scripts need some love |
Previous Message | Joshua D. Drake | 2006-09-10 19:09:24 | Re: contrib uninstall scripts need some love |