Re: .gitignore for some of cygwin files

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Radosław Smogura <rsmogura(at)softperience(dot)eu>
Cc: PG Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: .gitignore for some of cygwin files
Date: 2011-06-09 14:25:07
Message-ID: BANLkTin_XYhCMCaSHLOkArMT5Nrx0Fn-iA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jun 9, 2011 at 15:40, Radosław Smogura <rsmogura(at)softperience(dot)eu> wrote:
> On Thu, 9 Jun 2011 14:12:59 +0200, Magnus Hagander wrote:
>>
>> On Wed, Jun 8, 2011 at 12:34, Radosław Smogura
>> <rsmogura(at)softperience(dot)eu> wrote:
>>>
>>> After compilation I got big list of differences about binaries and other
>>> files. You may see it in patch.
>>
>> Hmm. Does this really affect just cygwin, and not also mingw? I know
>> msvc builds out-of-tree, but mingw doesn't, iirc? WHere do the EXEs go
>> there?
>>
>> What's "nbproject"?
>>
>> As for the patch itself, we don't normally keep comments in the
>> .gitignore files, I'm not sure if we want to start doing that...
>
> Sorry for trash this is `git status` after compilation on branch
>
> #       .gitignore-for-cygwin.diff
> #       blob_20110601.patch
> #       nbproject/
> #       src/backend/postgres.def
> #       src/backend/postgres.exe
> #       src/backend/replication/libpqwalreceiver/liblibpqwalreceiverdll.def
> #       src/backend/snowball/libdict_snowballdll.def
> #       src/backend/utils/adt/blob.c
> #
> src/backend/utils/mb/conversion_procs/ascii_and_mic/libascii_and_micdll.def
> #
> src/backend/utils/mb/conversion_procs/cyrillic_and_mic/libcyrillic_and_micdll.def
> #
> src/backend/utils/mb/conversion_procs/euc2004_sjis2004/libeuc2004_sjis2004dll.def
> #
> src/backend/utils/mb/conversion_procs/euc_cn_and_mic/libeuc_cn_and_micdll.def
> #
> src/backend/utils/mb/conversion_procs/euc_jp_and_sjis/libeuc_jp_and_sjisdll.def
> #
> src/backend/utils/mb/conversion_procs/euc_kr_and_mic/libeuc_kr_and_micdll.def
> #
> src/backend/utils/mb/conversion_procs/euc_tw_and_big5/libeuc_tw_and_big5dll.def
> #
> src/backend/utils/mb/conversion_procs/latin2_and_win1250/liblatin2_and_win1250dll.def
> #
> src/backend/utils/mb/conversion_procs/latin_and_mic/liblatin_and_micdll.def
> #
> src/backend/utils/mb/conversion_procs/utf8_and_ascii/libutf8_and_asciidll.def
> #
> src/backend/utils/mb/conversion_procs/utf8_and_big5/libutf8_and_big5dll.def
> #
> src/backend/utils/mb/conversion_procs/utf8_and_cyrillic/libutf8_and_cyrillicdll.def
> #
> src/backend/utils/mb/conversion_procs/utf8_and_euc2004/libutf8_and_euc2004dll.def
> #
> src/backend/utils/mb/conversion_procs/utf8_and_euc_cn/libutf8_and_euc_cndll.def
> #
> src/backend/utils/mb/conversion_procs/utf8_and_euc_jp/libutf8_and_euc_jpdll.def
> #
> src/backend/utils/mb/conversion_procs/utf8_and_euc_kr/libutf8_and_euc_krdll.def
> #
> src/backend/utils/mb/conversion_procs/utf8_and_euc_tw/libutf8_and_euc_twdll.def
> #
> src/backend/utils/mb/conversion_procs/utf8_and_gb18030/libutf8_and_gb18030dll.def
> #
> src/backend/utils/mb/conversion_procs/utf8_and_gbk/libutf8_and_gbkdll.def
> #
> src/backend/utils/mb/conversion_procs/utf8_and_iso8859/libutf8_and_iso8859dll.def
> #
> src/backend/utils/mb/conversion_procs/utf8_and_iso8859_1/libutf8_and_iso8859_1dll.def
> #
> src/backend/utils/mb/conversion_procs/utf8_and_johab/libutf8_and_johabdll.def
> #
> src/backend/utils/mb/conversion_procs/utf8_and_sjis/libutf8_and_sjisdll.def
> #
> src/backend/utils/mb/conversion_procs/utf8_and_sjis2004/libutf8_and_sjis2004dll.def
> #
> src/backend/utils/mb/conversion_procs/utf8_and_uhc/libutf8_and_uhcdll.def
> #
> src/backend/utils/mb/conversion_procs/utf8_and_win/libutf8_and_windll.def
> #       src/bin/initdb/initdb.exe
> #       src/bin/pg_basebackup/pg_basebackup.exe
> #       src/bin/pg_config/pg_config.exe
> #       src/bin/pg_controldata/pg_controldata.exe
> #       src/bin/pg_ctl/pg_ctl.exe
> #       src/bin/pg_dump/pg_dump.exe
> #       src/bin/pg_dump/pg_dumpall.exe
> #       src/bin/pg_dump/pg_restore.exe
> #       src/bin/pg_resetxlog/pg_resetxlog.exe
> #       src/bin/psql/psql.exe
> #       src/bin/scripts/clusterdb.exe
> #       src/bin/scripts/createdb.exe
> #       src/bin/scripts/createlang.exe
> #       src/bin/scripts/createuser.exe
> #       src/bin/scripts/dropdb.exe
> #       src/bin/scripts/droplang.exe
> #       src/bin/scripts/dropuser.exe
> #       src/bin/scripts/reindexdb.exe
> #       src/bin/scripts/vacuumdb.exe
> #       src/include/utils/blob.h
> #       src/interfaces/ecpg/preproc/ecpg.exe
> #       src/pl/plpgsql/src/libplpgsqldll.def
> #       src/test/regress/libregressdll.def
> #       src/test/regress/pg_regress.exe
> #       src/timezone/zic.exe

Based on this list, a global exclude for "*.exe" and "lib*dll.def"
seems reasonable. Andrew, does that seem right to you as well? I
definitely want to keep the nbproject thing out of there, that belongs
in a personal exclude.

utils/adt/blob.c and include/utils/blob.h - what is that? That's
something that's actually from your development work and should not be
ignored, right?

--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2011-06-09 14:27:06 Re: release slippage
Previous Message Robert Haas 2011-06-09 14:24:16 Re: Invalid byte sequence for encoding "UTF8", caused due to non wide-char-aware downcase_truncate_identifier() function on WINDOWS