| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | startupBufferPinWaitBufId vs. ProcGlobalShmemSize |
| Date: | 2011-06-14 17:45:41 |
| Message-ID: | BANLkTinOpT9dq_76zyNHDame0ZU2u=CLKw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
ProcGlobalShmemSize() currently includes code to allow space for
startupBufferPinWaitBufId. But I think that's redundant, because that
variable is stored in PROC_HDR *ProcGlobal, for which this function is
separately allocating space.
So I propose to apply the attached patch, barring objections.
I see no reason to back-patch this, since allocating an extra 4 bytes
of shared memory is hardly anything to get excited about.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| Attachment | Content-Type | Size |
|---|---|---|
| procglobalshmemsize-cleanup.patch | application/octet-stream | 456 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2011-06-14 17:50:12 | Re: procpid? |
| Previous Message | Jaime Casanova | 2011-06-14 17:43:05 | Re: procpid? |