Re: Patch to allow domains over composite types

On Wed, May 11, 2011 at 8:07 AM, Yeb Havinga <yebhavinga(at)gmail(dot)com> wrote:
> typecmds.c says:
> "Domains over composite types might be made to work in the future, but not
> today."
>
> Attached is a patch that allows domains over composite types, together with
> test cases in domaincomp.sql. A domain over a composite type has typtype
> TYPTYPE_DOMAIN, but typrelid and typrelkind are empty: that information is
> only available in the pg_type record of the base type. The remainder of the
> patch follows from that choice. While parsing a record expression into a row
> type, an extra coercion node had to be inserted to ensure that the domain
> checks are called.
>
> All regression tests are ok, comments are highly appreciated.

I don't have time to look at this right now, but please add it to the
currently-open CommitFest:

https://commitfest.postgresql.org/action/commitfest_view/open

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company