| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Jaime Casanova <jaime(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: time-delayed standbys |
| Date: | 2011-05-11 11:16:11 |
| Message-ID: | BANLkTin4bCFrFX-n8JVG7QfzdYhVDBWnJQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, May 11, 2011 at 6:50 PM, Heikki Linnakangas
<heikki(dot)linnakangas(at)enterprisedb(dot)com> wrote:
> I think we can just always call ShutdownWalRcv(). It should be gone if the
> server was promoted while streaming, but that's just an implementation
> detail of what the promotion code does. There's no hard reason why it
> shouldn't be running at that point anymore, as long as we kill it before
> going any further.
Okay. But I'd like to add the following assertion check just before
ShutdownWalRcv() which you added, in order to detect such a bug
that we found this time, i.e., the bug which causes unexpected end
of recovery. Thought?
Assert(reachedStopPoint || !WalRcvInProgress())
> Committed a patch to do that.
Thanks. Should we backport it to 9.0? 9.0 has the same problem.
Regards,
--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2011-05-11 11:50:45 | Re: the big picture for index-only scans |
| Previous Message | Robert Haas | 2011-05-11 10:57:39 | Re: the big picture for index-only scans |