Re: [COMMITTERS] pgsql: Make the visibility map crash-safe.

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
Cc: Robert Haas <rhaas(at)postgresql(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Make the visibility map crash-safe.
Date: 2011-06-22 13:12:36
Message-ID: BANLkTin44Ur6sWMYVsGoSz-w_yJbOf5Dkw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Wed, Jun 22, 2011 at 6:55 AM, Heikki Linnakangas
<heikki(dot)linnakangas(at)enterprisedb(dot)com> wrote:
> On 22.06.2011 06:05, Robert Haas wrote:
>>
>> Second, when inserting, updating, or deleting
>> a tuple, we can no longer get away with clearing the visibility map
>> bit after releasing the lock on the corresponding heap page, because
>> an intervening crash might leave the visibility map bit set and the
>> page-level bit clear.
>
> heap_update seems to still do that.

Aw, crap. I'll take another look.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2011-06-22 13:43:48 pgsql: Don't select log_cnt in sequence regression tests.
Previous Message Heikki Linnakangas 2011-06-22 10:55:35 Re: [COMMITTERS] pgsql: Make the visibility map crash-safe.

Browse pgsql-hackers by date

  From Date Subject
Next Message Josh Kupershmidt 2011-06-22 13:14:47 Re: smallserial / serial2
Previous Message Bruce Momjian 2011-06-22 13:10:02 Re: Indication of db-shared tables