Re: pgindent weirdness

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: pgindent weirdness
Date: 2011-04-20 17:12:47
Message-ID: BANLkTimVk8LW90jfazbPtzGyNwnXnP24Fw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Apr 20, 2011 at 11:15 AM, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
> I did carefully warn you about the need to check the effects of the changes
> when I committed the new list.
>
> It looks like quite a few of the deletions come into this category, for
> example just looking at the diff here
> <https://github.com/postgres/postgres/commit/fe1438da8aa8a45f2cee816eb54841f97d3b2f22#src/tools/pgindent/typedefs.list>
> I see AggHashEntryData, AggStatePerAggData, AllocBlockData, and
> AllocChunkData from among the first few that were deleted and all are in the
> same category.

This implies to me that we changed something about how we handle this
since we did the 9.0 runs, but I don't know what it was. Should I?

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2011-04-20 17:16:50 Re: pgindent weirdness
Previous Message Robert Haas 2011-04-20 17:10:19 Re: pg_dump --binary-upgrade vs. ALTER TYPE ... DROP ATTRIBUTE