From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
---|---|
To: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
Cc: | depesz(at)depesz(dot)com, pgsql-bugs(at)postgresql(dot)org |
Subject: | Re: 9.1 doesn't start when died mid-backup |
Date: | 2011-04-14 05:25:02 |
Message-ID: | BANLkTikVrTUL7aB=jWZRd6VFqsDD=WTJ_Q@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs |
On Wed, Apr 13, 2011 at 8:18 PM, Heikki Linnakangas
<heikki(dot)linnakangas(at)enterprisedb(dot)com> wrote:
> Yep :-(. I'm thinking we need to revert that change, now that we know there
> was a reason for only checking the end-of-WAL when doing archive recovery
> after all. We can keep it as a warning, though. With a hint explaining that
> if you're doing crash recovery from a database that crashed while an online
> backup was in progress, it's ok, but if you're recovering from an online
> backup, the backup is broken.
Yeah, we cannot distinguish those two cases. I agree to emit such a warning.
> For backups taken with pg_basebackup in 9.1, we can add a flag to the
> backup_label, indicating that the backup was taken with pg_basebackup. For
> such backups, the above scenario really should not happen, and we can still
> make it a hard error if it does.
Agreed.
Regards,
--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
From | Date | Subject | |
---|---|---|---|
Next Message | Kevin Grittner | 2011-04-14 14:59:29 | Re: BUG #5974: UNION construct type cast gives poor error message |
Previous Message | Robert Haas | 2011-04-14 01:19:47 | Re: BUG #5856: pg_attribute.attinhcount is not correct. |