From: | Merlin Moncure <mmoncure(at)gmail(dot)com> |
---|---|
To: | Josh Kupershmidt <schmiddy(at)gmail(dot)com> |
Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: psql describe.c cleanup |
Date: | 2011-06-15 14:01:50 |
Message-ID: | BANLkTik31_V=6P=SyBJR9XQA1+bSEpxeaw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Jun 14, 2011 at 9:08 PM, Josh Kupershmidt <schmiddy(at)gmail(dot)com> wrote:
> On Tue, Jun 14, 2011 at 12:15 PM, Merlin Moncure <mmoncure(at)gmail(dot)com> wrote:
>> What I do wonder though is if the ; appending should really be
>> happening in printQuery() instead of in each query -- the idea being
>> that formatting for external consumption should be happening in one
>> place. Maybe that's over-thinking it though.
>
> That's a fair point, and hacking up printQuery() would indeed solve my
> original gripe about copy-pasting queries out of psql -E. But more
> generally, I think that standardizing the style of the code is a Good
> Thing, particularly where style issues impact usability (like here).
sure -- if anyone would like to comment on this one way or the other
feel free -- otherwise I'll pass the patch up the chain as-is...it's
not exactly the 'debate of the century' :-).
merlin
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Dunstan | 2011-06-15 14:05:37 | Re: pg_upgrade using appname to lock out other users |
Previous Message | Gurjeet Singh | 2011-06-15 13:44:30 | Re: procpid? |