Re: Foreign table permissions and cloning

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Shigeru Hanada <hanada(at)metrosystems(dot)co(dot)jp>, Thom Brown <thom(at)linux(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Foreign table permissions and cloning
Date: 2011-04-25 20:42:11
Message-ID: BANLkTi=ReUGvFAATZYWSjgdKVwHde_3TaA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Apr 25, 2011 at 2:31 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> ... There's a similar stanza for sequences, but that one uses
>> ereport(WARNING...) rather than ereport(ERROR...).  We could either
>> remove that stanza entirely (making foreign tables consistent with
>> views) or change ERROR to WARNING (making it consistent with
>> sequences).
>
> Well, the relevant point here is that there's little or no likelihood
> that we'll ever care to support direct UPDATE on sequences.  This is
> exactly not the case for foreign tables.  So I would argue that GRANT
> should handle them like views; certainly not be even more strict than
> it is for sequences.
>
> IOW, yeah, let's drop these two checks.

OK. Turned out a little more cleanup was needed to make this all the
way consistent with how we handle views; I have now done that.

<pauses to listen for screaming noises>

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Yves Weißig 2011-04-25 20:47:18 Re: operator classes for index?
Previous Message Robert Haas 2011-04-25 20:40:33 Re: branching for 9.2devel