| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp> |
| Cc: | Noah Misch <noah(at)leadboat(dot)com>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PgHacker <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [v9.2] DROP Reworks Part.0 - 'missing_ok' support of get_object_address |
| Date: | 2011-06-28 01:24:42 |
| Message-ID: | BANLkTi=Dc1pBk0b-kpQ8EgGv7JUx_FfHRQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jun 27, 2011 at 4:40 PM, Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp> wrote:
> The attached patch is rebased one towards the latest tree, using
> relation_openrv_extended().
Committed.
> Although it is not a matter in this patch itself, I found a problem on
> the upcoming patch
> that consolidate routines associated with DropStmt.
> Existing RemoveRelations() acquires a lock on the table owning an
> index to be removed
> in the case when OBJECT_INDEX is supplied.
> However, the revised get_object_address() opens the supplied relation
> (= index) in same
> time with lookup of its name. So, we may break down the
> relation_openrv_extended()
> into a pair of RangeVarGetRelid() and relation_open().
Not without looking at the patch. I will respond on that thread when
I've read through it more thoroughly.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Brendan Jurd | 2011-06-28 02:20:34 | Re: minor patch submission: CREATE CAST ... AS EXPLICIT |
| Previous Message | David Fetter | 2011-06-27 23:42:20 | Re: per-column generic option |