Re: Formatting Curmudgeons WAS: MMAP Buffers

On Sat, Apr 16, 2011 at 9:12 PM, Christopher Browne <cbbrowne(at)gmail(dot)com> wrote:
> On Sat, Apr 16, 2011 at 3:19 PM, Greg Smith <greg(at)2ndquadrant(dot)com> wrote:
>> Joshua Berkus wrote:
>>>
>>> Then you can say that politely and firmly with direct reference to the
>>> problem, rather than making the submitter feel bad.
>>>
>>
>> That's exactly what happened.  And then you responded that it was possible
>> to use a patch without fixing the formatting first.  That's not true, and
>> those of us who do patch review are tired of even trying.
>
> It would be worth a lot if we could get it enough easier to use
> pgindent, so that that could help *anyone* fix the formatting, as
> opposed to being something that Bruce runs once in a long while.
>
> If you can say, "here, run 'tools/frobozz/pg_indent' against each of
> your files, then resubmit the patch," and have at least a fighting
> chance of that being *nearly* right, that is a much nicer response to
> give those folks.
>
> Alternately, it would be nice if you could say, "I ran pgindent
> against your files, here's the revised patch, please do that yourself
> in future"

I agree.

But it turns out that it doesn't really matter. Whitespace or no
whitespace, if you don't read the diff before you hit send, it's
likely to contain some irrelevant cruft, whether whitespace changes or
otherwise.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company