Re: add (void) cast inside advance_aggregates for function ExecEvalExprSwitchContext

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: jian he <jian(dot)universality(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: add (void) cast inside advance_aggregates for function ExecEvalExprSwitchContext
Date: 2023-09-07 12:14:14
Message-ID: BA5F8D50-2E9C-4DC0-AF0F-2C5CCBE41731@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 3 Sep 2023, at 05:16, jian he <jian(dot)universality(at)gmail(dot)com> wrote:

> In src/backend/executor/nodeAgg.c
> 817: advance_aggregates(AggState *aggstate)
>
> Do we need to add "(void)" before ExecEvalExprSwitchContext?

I don't think we need to, but we could since we are in fact discardnig the
return value. Did you get a compiler warning on unchecked return, and if so
with which flags?

--
Daniel Gustafsson

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Hayato Kuroda (Fujitsu) 2023-09-07 12:24:23 RE: [PoC] pg_upgrade: allow to upgrade publisher node
Previous Message Daniel Gustafsson 2023-09-07 11:44:11 Re: Cutting support for OpenSSL 1.0.1 and 1.0.2 in 17~?