Re: [Proposal] Global temporary tables

From: 曾文旌 <wenjing(dot)zwj(at)alibaba-inc(dot)com>
To: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
Cc: Prabhat Sahu <prabhat(dot)sahu(at)enterprisedb(dot)com>, tushar <tushar(dot)ahuja(at)enterprisedb(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Konstantin Knizhnik <k(dot)knizhnik(at)postgrespro(dot)ru>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, "蔡松露(子嘉)" <zijia(at)taobao(dot)com>, "Cai, Le" <le(dot)cai(at)alibaba-inc(dot)com>
Subject: Re: [Proposal] Global temporary tables
Date: 2020-07-07 03:47:16
Message-ID: B975E259-97D3-4A28-8565-BB5A7CFC2207@alibaba-inc.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> 2020年7月6日 下午11:31,Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> 写道:
>
> Hi
>
> čt 11. 6. 2020 v 4:13 odesílatel 曾文旌 <wenjing(dot)zwj(at)alibaba-inc(dot)com <mailto:wenjing(dot)zwj(at)alibaba-inc(dot)com>> napsal:
>
>> 2020年6月9日 下午8:15,Prabhat Sahu <prabhat(dot)sahu(at)enterprisedb(dot)com <mailto:prabhat(dot)sahu(at)enterprisedb(dot)com>> 写道:
>>
>>
>>
>> On Wed, Apr 29, 2020 at 8:52 AM 曾文旌 <wenjing(dot)zwj(at)alibaba-inc(dot)com <mailto:wenjing(dot)zwj(at)alibaba-inc(dot)com>> wrote:
>>> 2020年4月27日 下午9:48,Prabhat Sahu <prabhat(dot)sahu(at)enterprisedb(dot)com <mailto:prabhat(dot)sahu(at)enterprisedb(dot)com>> 写道:
>>>
>>> Thanks Wenjing, for the fix patch for previous issues.
>>> I have verified the issues, now those fix look good to me.
>>> But the below error message is confusing(for gtt2).
>>>
>>> postgres=# drop table gtt1;
>>> ERROR: cannot drop global temp table gtt1 when other backend attached it.
>>>
>>> postgres=# drop table gtt2;
>>> ERROR: cannot drop index idx2 on global temp table gtt2 when other backend attached it.
>>>
>>> I feel the above error message shown for "DROP TABLE gtt2;" is a bit confusing(looks similar to DROP INDEX gtt2;).
>>> If possible, can we keep the error message simple as "ERROR: cannot drop global temp table gtt2 when other backend attached it."?
>>> I mean, without giving extra information for the index attached to that GTT.
>> Fixed the error message to make the expression more accurate. In v33.
>>
>> Thanks Wenjing. We verified your latest patch(gtt_v33) focusing on all reported issues and they work fine.
>> Thanks.
>> --
>
> I'm very glad to hear such good news.
> I am especially grateful for your professional work on GTT.
> Please feel free to let me know if there is anything you think could be improved.
>
>
> Thanks.
>
>
> Wenjing
>
> this patch needs rebase

GTT Merge the latest PGMaster and resolves conflicts.

Wenjing

>
> Regards
>
> Pavel
>
>
>> With Regards,
>> Prabhat Kumar Sahu
>> EnterpriseDB: http://www.enterprisedb.com <http://www.enterprisedb.com/>
>

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jeff Davis 2020-07-07 03:48:41 Re: Default setting for enable_hashagg_disk (hash_mem)
Previous Message movead.li@highgo.ca 2020-07-07 03:22:46 Re: pg_resetwal --next-transaction-id may cause database failed to restart.