| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | Thomas Krennwallner <tk(at)postsubmeta(dot)net>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_upgrade check for invalid databases |
| Date: | 2024-11-06 15:03:35 |
| Message-ID: | B838A9C5-E643-4B98-95E4-6BA5E2A1E16A@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 1 Nov 2024, at 01:36, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> On Fri, Oct 25, 2024 at 01:55:57PM +0200, Daniel Gustafsson wrote:
>> In the meantime, the OP has a good point that it's a tad silly that pg_upgrade
>> fails hard on invalid databases instead of detecting and reporting like how
>> other errors are handled. The attached adds this check and expands the report
>> wording to cover it.
>
> Agreed.
I've applied this part, the discussion on whether or not pg_upgrade should gain
capabilities to skip and/or fix issues should probably be carried over in a new
thread.
--
Daniel Gustafsson
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Karina Litskevich | 2024-11-06 15:09:25 | Re: Add missing tab completion for ALTER TABLE ADD COLUMN IF NOT EXISTS |
| Previous Message | Nazir Bilal Yavuz | 2024-11-06 14:56:41 | Re: Using read stream in autoprewarm |