| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Peter Geoghegan <pg(at)heroku(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Re: [COMMITTERS] pgsql: Add support for INSERT ... ON CONFLICT DO NOTHING/UPDATE. |
| Date: | 2015-05-21 11:41:37 |
| Message-ID: | B66C0757-BD88-499C-BF68-214F4BBAFEAE@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On May 20, 2015, at 9:22 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Andres Freund <andres(at)anarazel(dot)de> writes:
>> You realize there's other instances of this in the same damn function?
>
> Not to mention that several places in libpq/fe-exec.c should be
> taught about this new tag. And who-knows-what in other client-side
> libraries. I am not really sure that it was a good idea to invent
> this command tag. In fact, I'm pretty sure it was a *bad* idea ---
> what will happen if we ever create a statement actually named UPSERT?
>
> I think we should fix this by ripping out the variant tag, not trying
> to propagate it everywhere it would need to go.
+1
...Robert
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2015-05-21 11:52:09 | pgsql: Correct the names of pgstattuple_approx output columns in the do |
| Previous Message | Noah Misch | 2015-05-21 05:35:00 | Re: [COMMITTERS] pgsql: Add pg_audit, an auditing extension |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Grigory Kareev | 2015-05-21 11:50:30 | Add support for interface/ipaddress binding to libpq |
| Previous Message | Jan Bilek | 2015-05-21 11:32:18 | Postgres and TLSv1.2 |