From: | "Strong, David" <david(dot)strong(at)unisys(dot)com> |
---|---|
To: | <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Faster StrNCpy |
Date: | 2006-09-27 14:08:05 |
Message-ID: | B6419AF36AC8524082E1BC17DA2506E802579E0F@USMV-EXCH2.na.uis.unisys.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
We sometimes see TupleDescInitEntry () taking high CPU times via OProfile. This does include, amongst a lot of other code, a call to namestrcpy () which in turn calls StrNCpy (). Perhaps this is not a good candidate right now as a name string is only 64 bytes.
David
________________________________
From: pgsql-hackers-owner(at)postgresql(dot)org on behalf of Tom Lane
Sent: Wed 9/27/2006 6:49 AM
To: Andrew Dunstan
Cc: josh(at)agliodbs(dot)com; pgsql-hackers(at)postgresql(dot)org; Neil Conway; Martijn van Oosterhout
Subject: Re: [HACKERS] Faster StrNCpy
Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> Tom Lane wrote:
>> What I'd like to do immediately is put in strlcpy() and hit the two or
>> three places I think are performance-relevant.
> What are the other hotspots?
The ones I can think of offhand are set_ps_display and use of strncpy as
a HashCopyFunc.
regards, tom lane
---------------------------(end of broadcast)---------------------------
TIP 5: don't forget to increase your free space map settings
From | Date | Subject | |
---|---|---|---|
Next Message | Zdenek Kotala | 2006-09-27 14:09:18 | Re: horo(r)logy test fail on solaris (again and solved) |
Previous Message | Andrew Dunstan | 2006-09-27 13:56:10 | Re: Buildfarm alarms |
From | Date | Subject | |
---|---|---|---|
Next Message | Thomas Hallgren | 2006-09-27 20:00:59 | Re: [PATCHES] Patch for UUID datatype (beta) |
Previous Message | Tom Lane | 2006-09-27 13:49:26 | Re: Faster StrNCpy |