Re: [PATCH] PostgreSQL fails to build with 32bit MinGW-w64

From: NISHIYAMA Tomoaki <tomoakin(at)staff(dot)kanazawa-u(dot)ac(dot)jp>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: NISHIYAMA Tomoaki <tomoakin(at)staff(dot)kanazawa-u(dot)ac(dot)jp>, pgsql-hackers(at)postgresql(dot)org, Magnus Hagander <magnus(at)hagander(dot)net>
Subject: Re: [PATCH] PostgreSQL fails to build with 32bit MinGW-w64
Date: 2011-12-09 02:14:23
Message-ID: B6000E7D-8C8C-4610-AEFC-A8630D46F713@staff.kanazawa-u.ac.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

> FYI I've been testing with the attached patch.
> We'll need to construct a configure test for HAVE_CRTDEFS_H.

Isn't it enough to add the name in configure.in and run autoconf to
update configure and autoheaders to update pg_config.h.in?
The check of win32 before large file perhaps should also go to configure.in,
otherwise they would be wiped with next autoconf.

The patch recreated with removing the #undef
but adding the conditional to skip AC_SYS_LARGEFILE in configure.in and
update configure by autoconf.

Attachment Content-Type Size
pgsql-mingw-w64-patch.txt text/plain 7.7 KB
unknown_filename text/plain 2.1 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Joachim Wieland 2011-12-09 02:18:03 Re: pg_restore --no-post-data and --post-data-only
Previous Message Kohei KaiGai 2011-12-08 22:17:10 Re: [v9.2] Fix Leaky View Problem