| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Mikhail Gribkov <youzhick(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: GUC for temporarily disabling event triggers |
| Date: | 2023-09-06 08:50:46 |
| Message-ID: | B577CEFD-06EA-402C-89CF-2599BC72564B@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 5 Sep 2023, at 17:29, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Tue, Sep 5, 2023 at 8:12 AM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>> The attached version of the patch replaces it with a boolean flag for turning
>> off all event triggers, and I also renamed it to the debug_xxx "GUC namespace"
>> which seemed more appropriate.
>
> I don't care for the debug_xxx renaming, myself. I think that should
> be reserved for things where we believe there's no reason to ever use
> it in production/real life, or for things whose purpose is to emit
> debugging messages. Neither is the case here.
Fair enough, how about disable_event_trigger instead as per the attached?
--
Daniel Gustafsson
| Attachment | Content-Type | Size |
|---|---|---|
| v7-0001-Add-GUC-for-temporarily-disabling-event-triggers.patch | application/octet-stream | 8.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2023-09-06 08:55:47 | Re: [PoC] pg_upgrade: allow to upgrade publisher node |
| Previous Message | shveta malik | 2023-09-06 08:48:52 | Re: Synchronizing slots from primary to standby |