Re: changed behavior in libpq odbc driver

Hi All,

Here is a patch for the following bug pointed out by Scot.

"SQLGetConnectAttr with SQL_ATTR_CONNECTION_DEAD doesn't seem to work
anymore."

I request you to review this patch.

Regards

Anoop

> -----Original Message-----
> From: Dave Page [mailto:dpage(at)vale-housing(dot)co(dot)uk]
> Sent: Thursday, August 25, 2005 2:16 PM
> To: Anoop Kumar; dpage(at)vale-housing(dot)co(dot)uk; sloach(at)sandvine(dot)com
> Cc: pgsql-odbc(at)postgresql(dot)org
> Subject: RE: [ODBC] changed behavior in libpq odbc driver
>
> Thanks :-)
>
>
> -----Original Message-----
> From: "Anoop Kumar"<anoopk(at)pervasive-postgres(dot)com>
> Sent: 25/08/05 06:56:58
> To: "Dave Page"<dpage(at)vale-housing(dot)co(dot)uk>, "Scot
> Loach"<sloach(at)sandvine(dot)com>
> Cc: "pgsql-odbc(at)postgresql(dot)org"<pgsql-odbc(at)postgresql(dot)org>
> Subject: RE: [ODBC] changed behavior in libpq odbc driver
>
> Hi Dave,
>
> OK, I shall look into the state code problem and dead connection
> detection issues. :-)
>
> Regards
>
> Anoop
>
> > -----Original Message-----
> > From: Dave Page [mailto:dpage(at)vale-housing(dot)co(dot)uk]
> > Sent: Wednesday, August 24, 2005 3:16 PM
> > To: Anoop Kumar; Scot Loach
> > Cc: pgsql-odbc(at)postgresql(dot)org
> > Subject: RE: [ODBC] changed behavior in libpq odbc driver
> >
> >
> >
> > > -----Original Message-----
> > > From: pgsql-odbc-owner(at)postgresql(dot)org
> > > [mailto:pgsql-odbc-owner(at)postgresql(dot)org] On Behalf Of Anoop Kumar
> > > Sent: 24 August 2005 07:17
> > > To: Scot Loach
> > > Cc: pgsql-odbc(at)postgresql(dot)org
> > > Subject: Re: [ODBC] changed behavior in libpq odbc driver
> > >
> > > Hi,
> > >
> > > I have committed the patch for returning SQL_NO_DATA_FOUND instead
> of
> > > SQL_SUCCESS when no rows got affected in UPDATE/DELETE. You
> > > may check it
> > > out from the CVS.
> >
> > Ahh, one less item on my todo :-)
> >
> > Do you intend to fix the state code problem and dead connection
> > detection issues reported by Scot as well?
> >
> > <sob story>it would really help me if you could as I've got a bunch
of
> > other stuff to do :-( </sob story>
> >
> > :-)
> >
> > Regards, Dave.
>
>
>
> -----Unmodified Original Message-----
> Hi Dave,
>
> OK, I shall look into the state code problem and dead connection
> detection issues. :-)
>
> Regards
>
> Anoop
>
> > -----Original Message-----
> > From: Dave Page [mailto:dpage(at)vale-housing(dot)co(dot)uk]
> > Sent: Wednesday, August 24, 2005 3:16 PM
> > To: Anoop Kumar; Scot Loach
> > Cc: pgsql-odbc(at)postgresql(dot)org
> > Subject: RE: [ODBC] changed behavior in libpq odbc driver
> >
> >
> >
> > > -----Original Message-----
> > > From: pgsql-odbc-owner(at)postgresql(dot)org
> > > [mailto:pgsql-odbc-owner(at)postgresql(dot)org] On Behalf Of Anoop Kumar
> > > Sent: 24 August 2005 07:17
> > > To: Scot Loach
> > > Cc: pgsql-odbc(at)postgresql(dot)org
> > > Subject: Re: [ODBC] changed behavior in libpq odbc driver
> > >
> > > Hi,
> > >
> > > I have committed the patch for returning SQL_NO_DATA_FOUND instead
> of
> > > SQL_SUCCESS when no rows got affected in UPDATE/DELETE. You
> > > may check it
> > > out from the CVS.
> >
> > Ahh, one less item on my todo :-)
> >
> > Do you intend to fix the state code problem and dead connection
> > detection issues reported by Scot as well?
> >
> > <sob story>it would really help me if you could as I've got a bunch
of
> > other stuff to do :-( </sob story>
> >
> > :-)
> >
> > Regards, Dave.