From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
---|---|
To: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Error detail/hint style fixup |
Date: | 2018-03-19 15:41:23 |
Message-ID: | B3C002C8-21A0-4F53-A06E-8CAB29FCF295@yesql.se |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
When fixing review comments for error message style on another patch, I noticed
that there were a few error details/hints/contexts that weren’t following the
style guide in the documentation. This might be intentional from when they
were added, or we intentionally avoid changing after the fact to not impact
translations too much, or we just don’t care (didn’t find any past mention in
the archives though), but my OCD cannot unsee it now so I figured I'd send it
and see.
Attached patch ensures that (i) details and hints have leading capitalization,
have double spaces after punctuation and ends with period; (ii) context should
not be capitalized and should not end with period; (iii) test .out files match
the changes.
cheers ./daniel
Attachment | Content-Type | Size |
---|---|---|
errdetail_hint_style.patch | application/octet-stream | 69.0 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | David G. Johnston | 2018-03-19 15:48:34 | Re: Problems with Error Messages wrt Domains, Checks |
Previous Message | Robert Haas | 2018-03-19 15:38:32 | Re: inserts into partitioned table may cause crash |