Re: Making background psql nicer to use in tap tests

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Melanie Plageman <melanieplageman(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, mikael(dot)kjellstrom(at)gmail(dot)com
Subject: Re: Making background psql nicer to use in tap tests
Date: 2023-04-08 07:53:58
Message-ID: B379A518-74B0-48DA-8FF5-408EAAFE4679@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 8 Apr 2023, at 02:49, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> I wrote:
>> I've been doing some checking with perlbrew locally. It appears to not
>> be about IO::Pty so much as IPC::Run: it works with IPC::Run 0.99 but
>> not 0.79. Still bisecting to identify exactly what's the minimum
>> okay version.
>
> The answer is: it works with IPC::Run >= 0.98. The version of IO::Pty
> doesn't appear significant; it works at least back to 1.00 from early
> 2002.

Thanks for investigating this!

> IPC::Run 0.98 is relatively new (2018), so I don't think it'd fly
> to make that our new minimum version across-the-board.

Absolutely, that's not an option.

> I recommend
> just setting up this one test to SKIP if IPC::Run is too old.

Yes, will do that when I have a little more time at hand for monitoring the BF
later today.

--
Daniel Gustafsson

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Mikael Kjellström 2023-04-08 08:00:50 Re: Making background psql nicer to use in tap tests
Previous Message Bertrand Drouvot 2023-04-08 06:52:27 Re: Minimal logical decoding on standbys