Re: pgsql: Make PostgreSQL::Test::Cluster compatible with all live branches

> On Mar 30, 2022, at 9:12 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>>>> On Mar 30, 2022, at 8:19 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> I think this means that its old Perl version misinterprets
>>> use parent -norequire, qw(PostgreSQL::Test::Cluster);
>>> as a request to include "parent.pm". Is there a more
>>> backwards-compatible way to spell that?
>
>> Not that I know of. Googling tells me it was a core module from 5.10.1. I can revert tomorrow if necessary :-(
>
> Hmm. I checked not too long ago, and these are the buildfarm
> animals that would be broken:
>
> prairiedog | 2022-03-23 05:04:02 | configure: using perl 5.8.3
> anole | 2022-03-24 10:40:08 | configure: using perl 5.8.8
> gharial | 2022-03-24 18:32:22 | configure: using perl 5.8.8
> locust | 2022-03-19 22:17:53 | configure: using perl 5.8.8
> gaur | 2022-03-19 15:00:54 | configure: using perl 5.8.9
>
> I could update prairiedog and gaur (... probably), but hard to say
> about the others.
>
> It seems kind of sad for a backwards-compatibility patch to force a
> major move of our minimum Perl version. OTOH, if there's no other
> good way to do it, maybe we gotta.
>
> Another possibility is that maybe parent.pm could be successfully
> installed into a 5.8.x installation. I can't speak for those
> other animals, but mine at least are already frankencritters.
>
>

I think it can be salvaged. See https://fastapi.metacpan.org/source/CORION/parent-0.238/lib/parent.pm

Cheers

Andrew