Re: perlcritic: prohibit map and grep in void conext

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: perlcritic: prohibit map and grep in void conext
Date: 2021-07-27 19:09:10
Message-ID: B10A5F4F-ACB6-4B47-9E96-7855FEB0AEB5@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 27 Jul 2021, at 18:06, Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org> wrote:

> Attached is a patch that increases severity of that and the
> corresponding `grep` policy to 5 to enable it in our perlcritic policy,
> and fixes the one use that had already snuck in.

+1, the use of foreach also improves readability a fair bit IMO.

--
Daniel Gustafsson https://vmware.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2021-07-27 19:36:14 Re: Have I found an interval arithmetic bug?
Previous Message Pavel Stehule 2021-07-27 18:45:34 Re: RFC: Logging plan of the running query