From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
---|---|
To: | Magnus Hagander <magnus(at)hagander(dot)net> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>, Bruce Momjian <bruce(at)momjian(dot)us>, Maciek Sakrejda <m(dot)sakrejda(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Joel Jacobson <joel(at)compiler(dot)org>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Gabriele Bartolini <gabriele(dot)bartolini(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Possibility to disable `ALTER SYSTEM` |
Date: | 2024-03-18 15:44:20 |
Message-ID: | B0918797-FCC8-4E81-8CD7-0AFC8E798830@yesql.se |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> On 18 Mar 2024, at 16:34, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
>
> On Mon, Mar 18, 2024 at 2:09 PM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>>
>>> On 18 Mar 2024, at 13:57, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>>
>>> my proposal is something like this, taking a
>>> bunch of text from Jelte's patch and some inspiration from Magnus's
>>> earlier remarks:
>>
>> I still think any wording should clearly mention that settings in the file are
>> still applied. The proposed wording says to implicitly but to avoid confusion
>> I think it should be explicit.
>
> I haven't kept up with the thread, but in general I'd prefer it to
> actually turn off parsing the file as well. I think just turning off
> the ability to change it -- including the ability to *revert* changes
> that were made to it before -- is going to be confusing.
Wouldn't that break pgBackrest which IIRC write to .auto.conf directly
without using ALTER SYSTEM?
> But, if we have decided it shouldn't do that, then IMHO we should
> consider naming it maybe enable_alter_system_command instead -- since
> we're only disabling the alter system command, not the actual feature
> in total.
Good point.
--
Daniel Gustafsson
From | Date | Subject | |
---|---|---|---|
Next Message | Magnus Hagander | 2024-03-18 15:46:33 | Re: Possibility to disable `ALTER SYSTEM` |
Previous Message | Tom Lane | 2024-03-18 15:43:51 | Re: Add pg_basetype() function to obtain a DOMAIN base type |