| From: | Jelte Fennema <Jelte(dot)Fennema(at)microsoft(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [EXTERNAL] Re: Add ETIMEDOUT to ALL_CONNECTION_FAILURE_ERRNOS |
| Date: | 2021-10-01 07:14:05 |
| Message-ID: | AM5PR83MB0178264D3B73CF1D281E3BF7F7AB9@AM5PR83MB0178.EURPRD83.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Oops sorry, I did make that change locally but apparently didn't update my .patch file after committing, so I uploaded an intermediary one...
Thanks for fixing that.
I saw you added this section to the commit message:
> Perhaps this should be back-patched, but I'm hesitant to do so given
> the lack of previous complaints, and the hazard that there's a small
> ABI break on Windows from redefining the symbol. Even if we decide
> to do that, it'd be prudent to let this bake awhile in HEAD first.
Personally, I would love to see this backpatched. Since together with a second bug I reported[1] it's causing high query timeouts in Citus even if tcp_user_timeout is set to a low value. I do understand your worry though. Would a patch like the one I attached now be a better fit for a backport?
Jelte
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Consider-ETIMEDOUT-a-connection-failure-when-TCP_USE.patch | application/octet-stream | 1.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2021-10-01 07:17:09 | Re: Remove redundant initializations |
| Previous Message | Michael Paquier | 2021-10-01 07:12:27 | Re: Toast compression method options |