Re: [COMMITTERS] pgsql: Preventive maintenance in advance of pgindent run.

From: Piotr Stefaniak <postgres(at)piotr-stefaniak(dot)me>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Preventive maintenance in advance of pgindent run.
Date: 2017-05-17 18:13:16
Message-ID: AM3PR03MB1188858CCD55BC737C856F65F2E70@AM3PR03MB1188.eurprd03.prod.outlook.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 2017-05-17 19:16, Alvaro Herrera wrote:
> Tom Lane wrote:
>
>> Changing the pgindent rule for such cases sounds kind of promising,
>> but will anyone pursue it?
>
> We have someone who has studied the BSD indent code and even sent us
> patches to fix quite a few bugs, but we've largely ignored his efforts
> so far. I propose we take that indent as part of our repo, and patch it
> to our preferences.

That, I assume, would be me. Coincidentally, I'm about to push my fixes
upstream (FreeBSD). Before that happens, my changes can be obtained from
https://github.com/pstef/freebsd_indent and tested, if anyone wishes.

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2017-05-17 18:22:14 Re: [COMMITTERS] pgsql: Preventive maintenance in advance of pgindent run.
Previous Message Bruce Momjian 2017-05-17 18:05:32 Re: [COMMITTERS] pgsql: Preventive maintenance in advance of pgindent run.

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2017-05-17 18:16:30 Re: Hash Functions
Previous Message Bruce Momjian 2017-05-17 18:05:32 Re: [COMMITTERS] pgsql: Preventive maintenance in advance of pgindent run.