From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, Mikhail Gribkov <youzhick(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: GUC for temporarily disabling event triggers |
Date: | 2023-04-03 21:35:14 |
Message-ID: | AEFDB346-50F7-45BB-AE0C-3DCA931ACA8C@yesql.se |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> On 3 Apr 2023, at 16:09, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Mon, Apr 3, 2023 at 9:15 AM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>>> On 3 Apr 2023, at 15:09, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>>> I continue to think it's odd that the sense of this is inverted as
>>> compared with row_security.
>>
>> I'm not sure I follow. Do you propose that the GUC enables classes of event
>> triggers, the default being "all" (or similar) and one would remove the type of
>> EVT for which debugging is needed? That doesn't seem like a bad idea, just one
>> that hasn't come up in the discussion (and I didn't think about).
>
> Right. Although to be fair, that idea doesn't sound as good if we're
> going to have settings other than "on" or "off".
Yeah. The patch as it stands allow for disabling specific types rather than
all-or-nothing, which is why the name was "ignore".
> I'm not sure what the best thing to do is here, I just think it
> deserves some thought.
Absolutely, the discussion is much appreciated. Having done some thinking I
think I'm still partial to framing it as a disabling GUC rather than an
enabling; with the act of setting it being "As an admin I want to skip
execution of all evt's of type X".
--
Daniel Gustafsson
From | Date | Subject | |
---|---|---|---|
Next Message | Gregory Stark (as CFM) | 2023-04-03 21:38:13 | Re: WIP: Aggregation push-down - take2 |
Previous Message | Tomas Vondra | 2023-04-03 21:26:09 | Re: zstd compression for pg_dump |