Re: pgsql: Set libpq sslcompression to off by default

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Set libpq sslcompression to off by default
Date: 2018-03-17 19:12:25
Message-ID: ADA33C10-48FF-4667-B1F2-0860C7564436@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

> On 17 Mar 2018, at 17:47, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
>> Set libpq sslcompression to off by default
>
> Buildfarm reports that SSL_clear_options isn't available everywhere.

Per some reading of the documentation and various patchers it seems
SSL_clear_options() was introduced in 0.9.8m and SSL_OP_NO_COMPRESSION in
1.0.0. For older versions, the recommended option is to clear the list of
compression methods in order to disable compression:

#ifndef SSL_OP_NO_COMPRESSION
STACK_OF(SSL_COMP)* comp_methods;
comp_methods = SSL_COMP_get_compression_methods();
sk_SSL_COMP_zero(comp_methods);
#endif

I don’t have an old version handy to try on, so the above is untested.

cheers ./daniel

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2018-03-17 19:38:41 pgsql: Fix overflow handling in plpgsql's integer FOR loops.
Previous Message Tom Lane 2018-03-17 19:00:11 pgsql: Fix WHERE CURRENT OF when the referenced cursor uses an index-on