From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
---|---|
To: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
Cc: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Andres Freund <andres(at)anarazel(dot)de>, Onder Kalaci <onder(at)citusdata(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [HACKERS] Optional message to user when terminating/cancelling backend |
Date: | 2018-08-12 08:29:52 |
Message-ID: | AD56BE31-0D74-4986-BCCB-1AADD14C5886@yesql.se |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> On 12 Aug 2018, at 07:42, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> wrote:
> 2018-08-12 0:17 GMT+02:00 Daniel Gustafsson <daniel(at)yesql(dot)se <mailto:daniel(at)yesql(dot)se>>:
> > On 6 Aug 2018, at 09:47, Heikki Linnakangas <hlinnaka(at)iki(dot)fi <mailto:hlinnaka(at)iki(dot)fi>> wrote:
> > What happens if the message contains non-ASCII characters, and the sending backend is connected to database that uses a different encoding than the backend being signaled?
>
> In the current state of the patch, instead of the message you get:
>
> FATAL: character with byte sequence 0xe3 0x82 0xbd in encoding "UTF8" has
> no equivalent in encoding “ISO_8859_5"
>
> Where this code fails? Isn't somewhere upper where string literals are translated? Then this message is ok.
This happens for example when a UTF-8 backend sends a message with japanese
characters to a backend using ISO_8859_5. So the code works as expected, but
it’s not a very good user experience.
cheers ./daniel
From | Date | Subject | |
---|---|---|---|
Next Message | Fabien COELHO | 2018-08-12 08:42:19 | Re: libpq should append auth failures, not overwrite |
Previous Message | David Rowley | 2018-08-12 08:07:50 | Re: Tid scan improvements |