Re: Re: custom hash-based COUNT(DISTINCT) aggregate - unexpectedly high memory consumption

From: Atri Sharma <atri(dot)jiit(at)gmail(dot)com>
To: Claudio Freire <klaussfreire(at)gmail(dot)com>
Cc: Tomas Vondra <tv(at)fuzzy(dot)cz>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Re: custom hash-based COUNT(DISTINCT) aggregate - unexpectedly high memory consumption
Date: 2013-10-08 07:17:10
Message-ID: AD08356B-0EFD-4C70-AFFD-EC39D547F243@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Sent from my iPad

> On 08-Oct-2013, at 10:41, Claudio Freire <klaussfreire(at)gmail(dot)com> wrote:
>
> On Tue, Oct 8, 2013 at 1:23 AM, Atri Sharma <atri(dot)jiit(at)gmail(dot)com> wrote:
>>>> Consider the aspects associated with open addressing.Open addressing
>>>> can quickly lead to growth in the main table.Also, chaining is a much
>>>> cleaner way of collision resolution,IMHO.
>>>
>>> What do you mean by "growth in the main table"?
>>
>> Sorry, I should have been more verbose.
>>
>> AFAIK, Open addressing can be slower with a load factor approaching 1
>> as compared to chaining. Also, I feel that implementation of open
>> addressing can be more complicated as we have to deal with deletes
>> etc.
>
>
> Deletes for a hash aggregate?

Yeah, that doesn't apply here.I was just listing out the demerits of open addressing :)

My point is, it is not wise to unnecessarily complicate matters by shifting to open addressing. If we want, we could look at changing the data structure used for chaining, but chaining is better for our requirements IMHO.

Regards,

Atri

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Haribabu kommi 2013-10-08 08:33:11 Re: Compression of full-page-writes
Previous Message Michael Paquier 2013-10-08 06:52:08 Re: [COMMITTERS] pgsql: Add DISCARD SEQUENCES command.