| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | yuzuko <yuzukohosoya(at)gmail(dot)com> |
| Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, Amit Langote <amitlangote09(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com>, Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Greg Stark <stark(at)mit(dot)edu> |
| Subject: | Re: Autovacuum on partitioned table (autoanalyze) |
| Date: | 2020-08-25 12:28:20 |
| Message-ID: | ACE6950A-7C00-4BFB-90DA-DEBFF870565C@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 17 Aug 2020, at 08:11, yuzuko <yuzukohosoya(at)gmail(dot)com> wrote:
>
> I'm sorry for the late reply.
>
>> This version seems to fail under Werror which is used in the Travis builds:
>>
>> autovacuum.c: In function ‘relation_needs_vacanalyze’:
>> autovacuum.c:3117:59: error: ‘reltuples’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
>> anlthresh = (float4) anl_base_thresh + anl_scale_factor * reltuples;
>> ^
>> autovacuum.c:2972:9: note: ‘reltuples’ was declared here
>> float4 reltuples; /* pg_class.reltuples */
>> ^
>
> I attach the latest patch that solves the above Werror.
> Could you please check it again?
This version now pass the tests in the Travis pipeline as can be seen in the
link below, and is ready to be reviewed in the upcoming commitfest:
http://cfbot.cputube.org/yuzuko-hosoya.html
cheers ./daniel
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ashutosh Sharma | 2020-08-25 12:38:38 | Re: recovering from "found xmin ... from before relfrozenxid ..." |
| Previous Message | Masahiko Sawada | 2020-08-25 12:17:05 | Re: recovering from "found xmin ... from before relfrozenxid ..." |