From: | Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com> |
---|---|
To: | Shigeru HANADA <hanada(at)metrosystems(dot)co(dot)jp> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: SQL/MED - core functionality |
Date: | 2011-01-05 11:37:25 |
Message-ID: | AANLkTinq=3SCRaCZnNkWZguX406V1cmO8ZsdudDU3Ffv@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Jan 5, 2011 at 19:24, Shigeru HANADA <hanada(at)metrosystems(dot)co(dot)jp> wrote:
> 2) foreign_scan.patch includes ForeignScan executor node and
> FdwRoutine interface
I can see now Iterate() callback is called in per-tuple memory context.
I'll adjust copy from API for the change. We don't need to export the
executor state in CopyState.
ForeignNext() still needs to materialize the slot. It seems reasonable
for me to add tts_tableoid to TupleTableSlot and modify slot_getattr()
to return the field for virtual and minimal tuples. Am I missing any
problems here?
Even if we still materialize tuples in 9.1, we would be better to use
ExecStoreVirtualTuple() in file_fdw and pgsql_fdw for future optimization.
--
Itagaki Takahiro
From | Date | Subject | |
---|---|---|---|
Next Message | Pavel Stehule | 2011-01-05 12:08:32 | Re: Support for negative index values in array fetching |
Previous Message | Florian Pflug | 2011-01-05 11:28:23 | Re: Support for negative index values in array fetching |