Re: Generalized edit function?

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Josh Berkus <josh(at)agliodbs(dot)com>
Cc: fork <forkandwait(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Generalized edit function?
Date: 2011-02-26 21:31:38
Message-ID: AANLkTinnjyMiM+vB=jsyQrsfc_qP7Wna698fee0UY8iz@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Feb 26, 2011 at 4:19 PM, Josh Berkus <josh(at)agliodbs(dot)com> wrote:
> Anyway, if it's ASCII-only, that's a guaranteed way to make sure it
> isn't taken seriously.

Pre-9.1 levenshtein is ASCII-only, and I think some of the other stuff
in contrib/fuzzystrmatch still is. We had to work pretty hard to
avoid a massive performance loss when we made it multi-byte aware, and
IIRC there is still a pretty significant performance loss if any
multibyte characters are actually present. But at least now it
doesn't return totally bogus answers.

So I have some sympathy with the OP's desire not to burden himself
with the non-ASCII case if he doesn't need it for his application, but
I also agree with your point that we probably wouldn't accept code
into contrib that doesn't.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Marko Tiikkaja 2011-02-26 22:01:45 Re: wCTE: why not finish sub-updates at the end, not the beginning?
Previous Message Josh Berkus 2011-02-26 21:19:46 Re: Generalized edit function?