Re: Parallel make problem with git master

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Jeff Davis <pgsql(at)j-davis(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Parallel make problem with git master
Date: 2011-03-08 14:33:36
Message-ID: AANLkTinfby2e-LuX=oPskw8xuXkq6u6-5ebyYj3O5Nne@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Mar 8, 2011 at 9:07 AM, Alvaro Herrera
<alvherre(at)commandprompt(dot)com> wrote:
> The bit I looked at, at the time, was src/backend/mb/conversion_procs,
> because that was where the biggest hit on parallelization was taken (a
> single lib at a time -- the real time CPU usage chart clearly showed the
> problem.  Not sure if that's still a problem).

I think it is, based on having noticed it spend what seemed like a
disproportionate amount of time on that stuff when building, but I
haven't actually tried to measure it.

>> I'm not sure whether it makes sense to go that far or not.  But I
>> think it'd make sense to at least try this for the backend.  It does
>> seem pretty silly to have a Makefile in every single directory.
>
> We already do that for the backend.  Not exactly a single Makefile, but
> the dependencies are all declared in indirectly in src/backend/Makefile
> with the common.mk tricks.

I'm not sure that's really the same thing. It'd be interesting to
redo it with just one Makefile and see whether it's faster.

> Where it doesn't work is in the other subdirs, c.f. the current problem
> with interfaces/libpq and interfaces/ecpg.  It would be a lot more
> difficult to fix there, I think, but maybe I'm wrong.

Yeah, that's a problem. I wondered if supplying -p to mkdir would
ameliorate the problem to some degree...

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Kevin Grittner 2011-03-08 14:39:56 Re: Beginner question: Hacking environment?
Previous Message Alvaro Herrera 2011-03-08 14:07:27 Re: Parallel make problem with git master